From 22a190a1db155e8aabdcf80d1ee9b6fc0159fa49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Tr=C3=A1vn=C3=AD=C4=8Dek?= <jan.travnicek@fit.cvut.cz> Date: Mon, 21 Feb 2022 04:45:55 +0100 Subject: [PATCH] cli: simplify the cli code a bit --- alib2cli/src/ast/expression/FunctionCallExpression.h | 2 -- alib2cli/src/ast/expression/ImmediateExpression.h | 6 ++---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/alib2cli/src/ast/expression/FunctionCallExpression.h b/alib2cli/src/ast/expression/FunctionCallExpression.h index d352512a32..26dea68ee9 100644 --- a/alib2cli/src/ast/expression/FunctionCallExpression.h +++ b/alib2cli/src/ast/expression/FunctionCallExpression.h @@ -16,8 +16,6 @@ public: } std::shared_ptr < abstraction::Value > translateAndEval ( Environment & environment ) const override { - std::shared_ptr < abstraction::Value > result; - ext::vector < std::shared_ptr < abstraction::Value > > params; for ( const std::unique_ptr < Expression > & param : m_params ) { std::shared_ptr < abstraction::Value > value = param->translateAndEval ( environment ); diff --git a/alib2cli/src/ast/expression/ImmediateExpression.h b/alib2cli/src/ast/expression/ImmediateExpression.h index 87decb17c7..f4ec4d6983 100644 --- a/alib2cli/src/ast/expression/ImmediateExpression.h +++ b/alib2cli/src/ast/expression/ImmediateExpression.h @@ -12,11 +12,9 @@ public: ImmediateExpression ( Type value ) : m_value ( std::move ( value ) ) { } - std::shared_ptr < abstraction::Value > translateAndEval ( Environment & environment ) const override { + std::shared_ptr < abstraction::Value > translateAndEval ( Environment & ) const override { Type copy = m_value; - std::shared_ptr < abstraction::ValueHolder < Type > > value = std::make_shared < abstraction::ValueHolder < Type > > ( std::move ( copy ), true ); - environment.holdTemporary ( value ); - return value; + return std::make_shared < abstraction::ValueHolder < Type > > ( std::move ( copy ), true ); } }; -- GitLab