From 9b6793dd64f3ce8e362807f57ee25f836da974ad Mon Sep 17 00:00:00 2001
From: Jan Travnicek <jan.travnicek@.fit.cvut.cz>
Date: Tue, 23 Jul 2019 12:05:03 +0200
Subject: [PATCH] fix some clang-tidy complaints
---
alib2abstraction/src/abstraction/PackingAbstraction.hpp | 4 ++--
alib2abstraction/src/abstraction/Value.cpp | 2 +-
alib2abstraction/src/abstraction/ValueHolder.hpp | 2 +-
alib2abstraction/src/abstraction/ValueHolderInterface.hpp | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/alib2abstraction/src/abstraction/PackingAbstraction.hpp b/alib2abstraction/src/abstraction/PackingAbstraction.hpp
index 67fe99f63f..22bc47866a 100644
--- a/alib2abstraction/src/abstraction/PackingAbstraction.hpp
+++ b/alib2abstraction/src/abstraction/PackingAbstraction.hpp
@@ -29,8 +29,8 @@ class PackingAbstraction : public OperationAbstraction {
public:
PackingAbstraction ( ext::vector < std::shared_ptr < abstraction::OperationAbstraction > > abstractions, size_t resultId ) : m_resultId ( resultId ) {
- for ( const std::shared_ptr < abstraction::OperationAbstraction > & abstraction : abstractions )
- m_abstractions.push_back ( std::make_shared < abstraction::LazyValue > ( abstraction ) );
+ for ( std::shared_ptr < abstraction::OperationAbstraction > & abstraction : abstractions )
+ m_abstractions.push_back ( std::make_shared < abstraction::LazyValue > ( std::move ( abstraction ) ) );
}
void setInnerConnection ( size_t sourceId, size_t targetId, size_t paramPosition, bool move ) {
diff --git a/alib2abstraction/src/abstraction/Value.cpp b/alib2abstraction/src/abstraction/Value.cpp
index a8a5e496d0..cb0f1de4dd 100644
--- a/alib2abstraction/src/abstraction/Value.cpp
+++ b/alib2abstraction/src/abstraction/Value.cpp
@@ -10,7 +10,7 @@
namespace abstraction {
-Value::Value ( std::shared_ptr < abstraction::OperationAbstraction > ref ) : m_lifeReference ( ref ) {
+Value::Value ( std::shared_ptr < abstraction::OperationAbstraction > ref ) : m_lifeReference ( std::move ( ref ) ) {
}
std::shared_ptr < abstraction::Value > Value::getProxyAbstraction ( ) {
diff --git a/alib2abstraction/src/abstraction/ValueHolder.hpp b/alib2abstraction/src/abstraction/ValueHolder.hpp
index 66321889b9..49068c4fd2 100644
--- a/alib2abstraction/src/abstraction/ValueHolder.hpp
+++ b/alib2abstraction/src/abstraction/ValueHolder.hpp
@@ -116,7 +116,7 @@ class ValueHolder : public ValueHolderImpl < Type > {
using ValueHolderImpl < Type >::ValueHolderImpl;
public:
- ValueHolder ( std::shared_ptr < abstraction::OperationAbstraction > ref, Type && value ) : ValueHolderImpl < Type > ( ref, std::is_const_v < std::remove_reference_t < Type > >, std::is_rvalue_reference_v < Type >, std::is_lvalue_reference_v < Type >, true ) {
+ ValueHolder ( std::shared_ptr < abstraction::OperationAbstraction > ref, Type && value ) : ValueHolderImpl < Type > ( std::move ( ref ), std::is_const_v < std::remove_reference_t < Type > >, std::is_rvalue_reference_v < Type >, std::is_lvalue_reference_v < Type >, true ) {
this->setData ( std::forward < Type > ( value ) );
}
diff --git a/alib2abstraction/src/abstraction/ValueHolderInterface.hpp b/alib2abstraction/src/abstraction/ValueHolderInterface.hpp
index 52ec5a55a4..d5b0c6c68a 100644
--- a/alib2abstraction/src/abstraction/ValueHolderInterface.hpp
+++ b/alib2abstraction/src/abstraction/ValueHolderInterface.hpp
@@ -20,7 +20,7 @@ class ValueHolderInterface : public Value {
bool m_isAutoMove;
public:
- ValueHolderInterface ( std::shared_ptr < abstraction::OperationAbstraction > ref, bool isConst, bool isRvalueRef, bool isLvalueRef, bool isAutoMove ) : Value ( ref ), m_isConst ( isConst ), m_isRvalueRef ( isRvalueRef ), m_isLvalueRef ( isLvalueRef ), m_isAutoMove ( isAutoMove ) {
+ ValueHolderInterface ( std::shared_ptr < abstraction::OperationAbstraction > ref, bool isConst, bool isRvalueRef, bool isLvalueRef, bool isAutoMove ) : Value ( std::move ( ref ) ), m_isConst ( isConst ), m_isRvalueRef ( isRvalueRef ), m_isLvalueRef ( isLvalueRef ), m_isAutoMove ( isAutoMove ) {
}
virtual Type && getValue ( ) const = 0;
--
GitLab