From ce58b255e4ca39164cd15e4ff25fc6c12b7986e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Tr=C3=A1vn=C3=AD=C4=8Dek?= <jan.travnicek@fit.cvut.cz> Date: Fri, 25 Feb 2022 21:59:40 +0100 Subject: [PATCH] tidy: use forward in NormalizeFactory --- alib2abstraction/src/factory/NormalizeFactory.hpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/alib2abstraction/src/factory/NormalizeFactory.hpp b/alib2abstraction/src/factory/NormalizeFactory.hpp index dcbcd0bb5a..61bcf57eae 100644 --- a/alib2abstraction/src/factory/NormalizeFactory.hpp +++ b/alib2abstraction/src/factory/NormalizeFactory.hpp @@ -46,19 +46,19 @@ public: template < class DesignatedType > static object::Object normalize ( DesignatedType && arg ) { if constexpr ( std::is_same_v < DesignatedType, object::Object > ) { - return std::move ( arg ); + return std::forward < DesignatedType > ( arg ); } else if constexpr ( is_variant_v < DesignatedType > ) { auto visitor = [] < class T > ( T && element ) { - return factory::NormalizeFactory::normalize < T > ( std::move ( element ) ); + return factory::NormalizeFactory::normalize < T > ( std::forward < T > ( element ) ); }; - return ext::visit ( visitor, std::move ( arg ) ); + return ext::visit ( visitor, std::forward < DesignatedType > ( arg ) ); } else { using normalizedType = typename std::decay < typename std::result_of < decltype ( & core::type_util < DesignatedType >::normalize ) ( DesignatedType && ) >::type >::type; if constexpr ( std::is_same_v < normalizedType, DesignatedType > ) { - return object::ObjectFactory < >::construct ( std::move ( arg ) ); + return object::ObjectFactory < >::construct ( std::forward < DesignatedType > ( arg ) ); } else { - return object::ObjectFactory < >::construct ( core::type_util < DesignatedType >::normalize ( std::move ( arg ) ) ); + return object::ObjectFactory < >::construct ( core::type_util < DesignatedType >::normalize ( std::forward < DesignatedType > ( arg ) ) ); } } } -- GitLab