webui-client issueshttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues2022-10-18T09:31:48+02:00https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/81Check keys in dialog components2022-10-18T09:31:48+02:00Hana LitavskáCheck keys in dialog componentsCheck prop key in
* input dialog
* input grammar
* output dialog
* output grammar
input automaton table and output automaton table should be ok now.Check prop key in
* input dialog
* input grammar
* output dialog
* output grammar
input automaton table and output automaton table should be ok now.Hana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/90Automaton/grammar input box: table and string should show the same input when...2022-10-16T14:56:43+02:00Tomáš PeckaAutomaton/grammar input box: table and string should show the same input when switchingIf you write input in the table then it is not persisted in the text area. Let's implement shared state and only fill the data.If you write input in the table then it is not persisted in the text area. Let's implement shared state and only fill the data.Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/87Automaton input - Tab jumps to wrong field2022-10-04T13:19:12+02:00Filip GregorAutomaton input - Tab jumps to wrong fieldWhen using the Input node with type Automaton, Table format, the cursor sometimes dissapears when creating new row.
How to reproduce:
- Create input node, Automaton, Table.
- Write into first row some states and press enter.
- This crea...When using the Input node with type Automaton, Table format, the cursor sometimes dissapears when creating new row.
How to reproduce:
- Create input node, Automaton, Table.
- Write into first row some states and press enter.
- This creates new row, try to write single letter, the cursor should dissapear after that.
- It also happens when you try to write under the delta, when writing one symbol the cursor immediately dissapers. This does not seem to happen when writing under the other columns.
It is particularly annoying when trying to tab to next field.
Tested on Firefox and Chromium.Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/82Introduce parser generators for ALT formats2022-05-13T12:04:50+02:00Tomáš PeckaIntroduce parser generators for ALT formatsThese handwritten parsers are hard to maintain.
Look e.g. into [peggy.js](https://github.com/peggyjs/peggy), the successor of peg.jsThese handwritten parsers are hard to maintain.
Look e.g. into [peggy.js](https://github.com/peggyjs/peggy), the successor of peg.jsTomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/37Restyle algorithm overload list element - it is too large2022-05-13T08:27:37+02:00Tomáš PeckaRestyle algorithm overload list element - it is too largeThe algorithm overload div still takes a lot of space. Finding a specific overload for algorithms like `string::Compose` is pain.
![Screenshot_2020-10-12_ALT_WebUI](/uploads/35f9c51bc59a60a4d7913ca459a1afb6/Screenshot_2020-10-12_ALT_Web...The algorithm overload div still takes a lot of space. Finding a specific overload for algorithms like `string::Compose` is pain.
![Screenshot_2020-10-12_ALT_WebUI](/uploads/35f9c51bc59a60a4d7913ca459a1afb6/Screenshot_2020-10-12_ALT_WebUI.png)
Ideas how to improve it:
- name of argument and its type can be on a single line. If the name of the argument is longer than (lets say) 15 characters, abbreviate it with `...`.
- I was actually thinking about removing the name of the parameter and repace it with the input index. But I see that we reference the name in the docs. This is something that can't probably be done better (parsing doxygen? probably not, thank you). In the future we should solve this on the `automata-library` level. Maybe use a docstring for each parameter separatelyinstead of the full doxygen (what do you think, @travnja3 ?)
- Result and its type similarly
- Smaller margins around those <code>hr</code> tags and Result and Parameters headers.
I think making it smaller at least about one third would be desirable.BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/75Add a form for automaton input2022-05-02T23:07:39+02:00Hana LitavskáAdd a form for automaton inputAdd form for table input. Discussed here https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/issues/51Add form for table input. Discussed here https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/issues/51BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/64Filter by return type / argument types2022-04-25T14:06:13+02:00Hana LitavskáFilter by return type / argument typesBPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/71Add input and output boxes with Parse2022-04-19T17:35:22+02:00Hana LitavskáAdd input and output boxes with ParseAdd input and output boxes for string input that will be parsed to grammar, automaton... Using string::Parse templated algorithm.Add input and output boxes for string input that will be parsed to grammar, automaton... Using string::Parse templated algorithm.BPHana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/78Grammar form does not add initial symbol into grammar's alphabet2022-04-17T10:59:25+02:00Tomáš PeckaGrammar form does not add initial symbol into grammar's alphabet![gform](/uploads/9062dcddd6ac144c9f5edd12b2c9df7d/gform.gif)
Tested on: d4d1827289b00de1564385547d640497e86c4dbb
![gform](/uploads/9062dcddd6ac144c9f5edd12b2c9df7d/gform.gif)
Tested on: d4d1827289b00de1564385547d640497e86c4dbb
Hana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/79Can't input CSG in grammar form2022-04-17T10:59:25+02:00Tomáš PeckaCan't input CSG in grammar formi don't know how to input the following grammar using the grammar form:
* CSG
* initial symbol `S`
* rules
* `S -> a`
* `c A B c -> c A A A A A A A c`
Evaluation ends with error `Evaluation of algorithm string::Parse failed. Parse ...i don't know how to input the following grammar using the grammar form:
* CSG
* initial symbol `S`
* rules
* `S -> a`
* `c A B c -> c A A A A A A A c`
Evaluation ends with error `Evaluation of algorithm string::Parse failed. Parse callback not registered.`
Tested on d4d1827289b00de1564385547d640497e86c4dbbHana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/67Return value tooltip on parameters2022-04-16T19:14:20+02:00Hana LitavskáReturn value tooltip on parametersSome algorithms have "return value" tooltip on parameter icons.
![return_value](/uploads/0726aaeaa642337459b610dee543a49e/return_value.png)Some algorithms have "return value" tooltip on parameter icons.
![return_value](/uploads/0726aaeaa642337459b610dee543a49e/return_value.png)BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/57show documentation for algorithm boxes on canvas2022-03-25T15:31:18+01:00Tomáš Peckashow documentation for algorithm boxes on canvasMaybe a small (i) icon that shows a popup with documentation.Maybe a small (i) icon that shows a popup with documentation.BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/73Fix height for boxes with more input parameters2022-03-25T15:31:16+01:00Hana LitavskáFix height for boxes with more input parametersFix height resizing ![node](/uploads/7acdba9dda5ef686c92c5c698446be0f/node.png)Fix height resizing ![node](/uploads/7acdba9dda5ef686c92c5c698446be0f/node.png)BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/52Verbose output nodes2022-03-25T15:31:16+01:00Tomáš PeckaVerbose output nodesThe verbose output nodes were introduced in !15.
However, they are kind of hacked in there. Worker just reports them as "output nodes" and the webui processes it just as it was an output node.
I think that from the view of the worker, it...The verbose output nodes were introduced in !15.
However, they are kind of hacked in there. Worker just reports them as "output nodes" and the webui processes it just as it was an output node.
I think that from the view of the worker, it is fine.
However, the webui should distinguish between an actual output node and "verbose node".
So, what I propose:
* The verbose output should be distinguished visually (another color might suffice)
* The verbose output should be typeset in verbatim as it is just a stream of printable bytes. Some algorithms, like `minimize` even try to print a table in plaintextBPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/66Reduce bundle size2022-02-20T13:55:19+01:00Tomáš PeckaReduce bundle sizeToday's build of 73460371 (this does not have the `algorithms.json` bundled anymore):
```
File sizes after gzip:
737.9 KB build/static/js/2.a28c4d21.chunk.js
35.84 KB build/static/js/main.364ca3d4.chunk.js
775 B build/stati...Today's build of 73460371 (this does not have the `algorithms.json` bundled anymore):
```
File sizes after gzip:
737.9 KB build/static/js/2.a28c4d21.chunk.js
35.84 KB build/static/js/main.364ca3d4.chunk.js
775 B build/static/js/runtime-main.595ff79e.js
135 B build/static/css/main.876345ae.chunk.css
```
Still too much I guess.
As per https://create-react-app.dev/docs/analyzing-the-bundle-size/:
Externals:
* 72.4% by viz.js (1.98 MB, graphviz dependency) !!!
* 6.2% by MUI (174 KB, not much to do I guess)
* 4.1% by react (114KB, not much to do I guess)
* 2.1% by immutable.js (60KB, used only for Maps in redux)
Our code is not that big.
Find out how to reduce viz.js size. Their [github repo](https://github.com/mdaines/viz.js/) says they compiled the C code with Emscripten :( Is there a way how not to bundle whole viz.js?Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/46Log higher priority messages to stderr2020-11-15T14:39:13+01:00Tomáš PeckaLog higher priority messages to stderrWe forward logs from docker containers to hosts journald in deployment. Docker [apparently](1) logs only stderr messages as critical. However, spdlog logs everything to stdout.
Probably we have to create two sinks for the worker loggers...We forward logs from docker containers to hosts journald in deployment. Docker [apparently](1) logs only stderr messages as critical. However, spdlog logs everything to stdout.
Probably we have to create two sinks for the worker loggers.
[1] https://github.com/docker/docker-ce/blob/96d50fd61df5a62a26609523619f5a5386b7d6db/components/engine/daemon/logger/journald/journald.go#L122Tomáš PeckaTomáš Pecka