webui-client issueshttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues2020-05-11T01:57:30+02:00https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/24Auto collapsing the left sidebar2020-05-11T01:57:30+02:00Tomáš PeckaAuto collapsing the left sidebarI am not sure about the automatic collapsing of the left sidebar when a node is placed. You usually want to place multiple nodes and it can get quite annoying after placing `n` nodes :-)
This is not a bug report. I do not have a strong ...I am not sure about the automatic collapsing of the left sidebar when a node is placed. You usually want to place multiple nodes and it can get quite annoying after placing `n` nodes :-)
This is not a bug report. I do not have a strong opinion about it. :-)
Maybe it will be something that the UI testers will report (if you decide to do the tests).
What do you think?Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/27Verify older browsers support2020-05-11T11:01:57+02:00Tomáš PeckaVerify older browsers supportPlease verify functionality with older but still supported browsers. Yesterday @jirutjak had some problems with Firefox ESR versions.Please verify functionality with older but still supported browsers. Yesterday @jirutjak had some problems with Firefox ESR versions.Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/30Cast failure highlight2020-05-19T18:50:35+02:00Tomáš PeckaCast failure highlightI do not get it why the Trim input is red. AFAIK only the output node of Trim and input of Output (you know what i mean) should be highlighted in red.
![Snímek_z_2020-05-19_14-58-14](/uploads/bb01887111ffb6cd58ba85cdc79a0315/Snímek_z_202...I do not get it why the Trim input is red. AFAIK only the output node of Trim and input of Output (you know what i mean) should be highlighted in red.
![Snímek_z_2020-05-19_14-58-14](/uploads/bb01887111ffb6cd58ba85cdc79a0315/Snímek_z_2020-05-19_14-58-14.png)Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/29Canvas grid and boxes2020-05-19T20:07:34+02:00Tomáš PeckaCanvas grid and boxesBox does not align with a grid. On the other hand it looks like the center of the box is "snapped" but not top-left corner.
If the anchor is in the middle please change it to top-left corner (if possible) as this is unintuitive (and the ...Box does not align with a grid. On the other hand it looks like the center of the box is "snapped" but not top-left corner.
If the anchor is in the middle please change it to top-left corner (if possible) as this is unintuitive (and the box dimension differs with the length of the label and it seems that even with the text-case of the label).
See attached picture - i tried to position string, parse and trim on the same line ![Snímek_z_2020-05-19_14-58-14](/uploads/10c6fef7469af7edb7214d16686e52e2/Snímek_z_2020-05-19_14-58-14.png)Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/20Save/Load algorithm sheet2020-05-23T19:28:33+02:00Tomáš PeckaSave/Load algorithm sheetPlease provide at least a basic way to save/load current algorithm graph (can the current inputs be serialized too?). This is crucial for teaching.
~~Save to local storage would be appreciated too.~~Please provide at least a basic way to save/load current algorithm graph (can the current inputs be serialized too?). This is crucial for teaching.
~~Save to local storage would be appreciated too.~~Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/33Save sheet to local storage2020-05-27T07:12:25+02:00Tomáš PeckaSave sheet to local storagehttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/26README2020-05-27T07:13:08+02:00Tomáš PeckaREADMEplease update README. It looks like the old one from statemaker :-)please update README. It looks like the old one from statemaker :-)Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/31Clear all2020-05-27T15:14:59+02:00Tomáš PeckaClear alladd clear all buttonadd clear all buttonhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/32Input connection - replace old one2020-05-28T00:37:32+02:00Tomáš PeckaInput connection - replace old onenew input connection should replace the old onenew input connection should replace the old onehttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/1Statemaker - undo2020-05-28T21:10:47+02:00Tomáš PeckaStatemaker - undoStatemaker's undos work also in the algorithm sheetStatemaker's undos work also in the algorithm sheetMichael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/28Deployment2020-05-31T15:07:00+02:00Tomáš PeckaDeploymentWhat I'd like to see (not important as of now):
* [x] Client: is it possible not to bundle src/config.js (the apiUrl) into the big JS file? So I do not have to specify the URL while building but pass it via environment or something like ...What I'd like to see (not important as of now):
* [x] Client: is it possible not to bundle src/config.js (the apiUrl) into the big JS file? So I do not have to specify the URL while building but pass it via environment or something like that. Is that even a good idea?
* [x] Server: CORS should be configurable from outside (again, I do not like compiling for specific URLs)
* [x] Server: optional logging - both HTTP and tasks
* [x] Worker: optional logging - what tasks are being evaluated? timestamps of start/end/timeout
* [x] redesign dockerfiles, maybe even the subprojects. Also the resulting images seem to be largeTomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/6Add keybinds2020-06-10T20:25:14+02:00Michael VránaAdd keybindshttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/35Import over API2020-10-07T17:01:39+02:00Michael VránaImport over API@peckato1
How would you want it to work? My idea would be to have an endpoint from which the webui would pull the JSONs and import them. We also need to decide how to store the JSONs. The simple solution would be to host the JSONs on a ...@peckato1
How would you want it to work? My idea would be to have an endpoint from which the webui would pull the JSONs and import them. We also need to decide how to store the JSONs. The simple solution would be to host the JSONs on a web server that would be accessed by the API server. Alternatively we can have a DB with the JSONs.Michael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/13Add help dialog2020-10-25T11:49:34+01:00Michael VránaAdd help dialogMichael VránaMichael Vránahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/39Simple string::Parse of automaton with dot output does not work2020-10-29T16:58:26+01:00Tomáš PeckaSimple string::Parse of automaton with dot output does not workSimple evaluation pipeline `input(string) -> parse(Automaton) -> dot output` fails with `Evaluation of algorithm convert::DotConverter failed.` although the input is valid. See attached notebook.
[webui_export__4_.json](/uploads/c4a8ed0...Simple evaluation pipeline `input(string) -> parse(Automaton) -> dot output` fails with `Evaluation of algorithm convert::DotConverter failed.` although the input is valid. See attached notebook.
[webui_export__4_.json](/uploads/c4a8ed0fb65a52b6b416a40dcddde8f5/webui_export__4_.json)Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/41Report more detailed errors2020-10-29T16:58:26+01:00Tomáš PeckaReport more detailed errorsMake worker report full ALT̈́ exception log (include nested exceptions). Perhaps pass that back to webui as structured JSON and visualize.Make worker report full ALT̈́ exception log (include nested exceptions). Perhaps pass that back to webui as structured JSON and visualize.Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/45Add a link to docs in string input dialog2020-10-30T15:48:20+01:00Tomáš PeckaAdd a link to docs in string input dialogthe formats may be confusingthe formats may be confusingTomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/44Crashed worker causes the job not to be removed from queue2020-11-07T18:33:10+01:00Tomáš PeckaCrashed worker causes the job not to be removed from queueso the other workers fetch the job and keep themselves busy crashing&restarting ...so the other workers fetch the job and keep themselves busy crashing&restarting ...Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/46Log higher priority messages to stderr2020-11-15T14:39:13+01:00Tomáš PeckaLog higher priority messages to stderrWe forward logs from docker containers to hosts journald in deployment. Docker [apparently](1) logs only stderr messages as critical. However, spdlog logs everything to stdout.
Probably we have to create two sinks for the worker loggers...We forward logs from docker containers to hosts journald in deployment. Docker [apparently](1) logs only stderr messages as critical. However, spdlog logs everything to stdout.
Probably we have to create two sinks for the worker loggers.
[1] https://github.com/docker/docker-ce/blob/96d50fd61df5a62a26609523619f5a5386b7d6db/components/engine/daemon/logger/journald/journald.go#L122Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/43Worker sometimes fails with pure virtual method called2021-02-07T11:59:30+01:00Tomáš PeckaWorker sometimes fails with pure virtual method calledIt happened twice. This crashes the worker but the job is still in the server's queue.
I started workers in debug mode in production, we shall see whether this happens again.It happened twice. This crashes the worker but the job is still in the server's queue.
I started workers in debug mode in production, we shall see whether this happens again.Tomáš PeckaTomáš Pecka