webui-client issueshttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues2022-12-04T12:36:44+01:00https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/92Grammars can't have digits as terminals2022-12-04T12:36:44+01:00Filip GregorGrammars can't have digits as terminalsSee the image
![image](/uploads/10f155a65a3774ec6e520d0e5d35b555/image.png)See the image
![image](/uploads/10f155a65a3774ec6e520d0e5d35b555/image.png)Tomáš PeckaTomáš Pecka2022-12-01https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/91Internal error after Determinize -> Total2022-10-19T21:56:59+02:00Tomáš PeckaInternal error after Determinize -> Totalhttps://alt.fit.cvut.cz/webui/?s=6ABabzH7jr3jIWuDLPlkkjhttps://alt.fit.cvut.cz/webui/?s=6ABabzH7jr3jIWuDLPlkkjTomáš PeckaTomáš Pecka2022-10-19https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/90Automaton/grammar input box: table and string should show the same input when...2022-10-16T14:56:43+02:00Tomáš PeckaAutomaton/grammar input box: table and string should show the same input when switchingIf you write input in the table then it is not persisted in the text area. Let's implement shared state and only fill the data.If you write input in the table then it is not persisted in the text area. Let's implement shared state and only fill the data.Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/88Input Automaton Table doesn't accept digits as symbols2022-10-04T09:55:31+02:00Filip GregorInput Automaton Table doesn't accept digits as symbols![image](/uploads/86cc4dcbeba99af1c2cf8a70e40ca918/image.png)![image](/uploads/86cc4dcbeba99af1c2cf8a70e40ca918/image.png)Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/87Automaton input - Tab jumps to wrong field2022-10-04T13:19:12+02:00Filip GregorAutomaton input - Tab jumps to wrong fieldWhen using the Input node with type Automaton, Table format, the cursor sometimes dissapears when creating new row.
How to reproduce:
- Create input node, Automaton, Table.
- Write into first row some states and press enter.
- This crea...When using the Input node with type Automaton, Table format, the cursor sometimes dissapears when creating new row.
How to reproduce:
- Create input node, Automaton, Table.
- Write into first row some states and press enter.
- This creates new row, try to write single letter, the cursor should dissapear after that.
- It also happens when you try to write under the delta, when writing one symbol the cursor immediately dissapers. This does not seem to happen when writing under the other columns.
It is particularly annoying when trying to tab to next field.
Tested on Firefox and Chromium.Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/82Introduce parser generators for ALT formats2022-05-13T12:04:50+02:00Tomáš PeckaIntroduce parser generators for ALT formatsThese handwritten parsers are hard to maintain.
Look e.g. into [peggy.js](https://github.com/peggyjs/peggy), the successor of peg.jsThese handwritten parsers are hard to maintain.
Look e.g. into [peggy.js](https://github.com/peggyjs/peggy), the successor of peg.jsTomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/81Check keys in dialog components2022-10-18T09:31:48+02:00Hana LitavskáCheck keys in dialog componentsCheck prop key in
* input dialog
* input grammar
* output dialog
* output grammar
input automaton table and output automaton table should be ok now.Check prop key in
* input dialog
* input grammar
* output dialog
* output grammar
input automaton table and output automaton table should be ok now.Hana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/80Let output nodes decide their features from the actual visualized type2022-04-25T17:15:15+02:00Jan TrávníčekLet output nodes decide their features from the actual visualized typehttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/merge_requests/47#note_276115https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/merge_requests/47#note_276115Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/79Can't input CSG in grammar form2022-04-17T10:59:25+02:00Tomáš PeckaCan't input CSG in grammar formi don't know how to input the following grammar using the grammar form:
* CSG
* initial symbol `S`
* rules
* `S -> a`
* `c A B c -> c A A A A A A A c`
Evaluation ends with error `Evaluation of algorithm string::Parse failed. Parse ...i don't know how to input the following grammar using the grammar form:
* CSG
* initial symbol `S`
* rules
* `S -> a`
* `c A B c -> c A A A A A A A c`
Evaluation ends with error `Evaluation of algorithm string::Parse failed. Parse callback not registered.`
Tested on d4d1827289b00de1564385547d640497e86c4dbbHana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/78Grammar form does not add initial symbol into grammar's alphabet2022-04-17T10:59:25+02:00Tomáš PeckaGrammar form does not add initial symbol into grammar's alphabet![gform](/uploads/9062dcddd6ac144c9f5edd12b2c9df7d/gform.gif)
Tested on: d4d1827289b00de1564385547d640497e86c4dbb
![gform](/uploads/9062dcddd6ac144c9f5edd12b2c9df7d/gform.gif)
Tested on: d4d1827289b00de1564385547d640497e86c4dbb
Hana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/77Fix grammar form validation for digits2022-04-17T10:59:25+02:00Hana LitavskáFix grammar form validation for digitsSymbol shouldn't start with digit.
When symbol `0b` is input and is submited with DONE button, the snackbar with error is shown but the form will close anyway and must be reopened for correction.Symbol shouldn't start with digit.
When symbol `0b` is input and is submited with DONE button, the snackbar with error is shown but the form will close anyway and must be reopened for correction.https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/76Adapt to changes in Determinize registrations in the core2022-05-14T19:25:38+02:00Tomáš PeckaAdapt to changes in Determinize registrations in the coreCommit https://gitlab.fit.cvut.cz/algorithms-library-toolkit/automata-library/commit/1a4de925c48aace75ff364fbc85dc7d8ffac5924?merge_request_iid=227 in the core merged all the no-op Determinize overloads into one.
This brings two issues....Commit https://gitlab.fit.cvut.cz/algorithms-library-toolkit/automata-library/commit/1a4de925c48aace75ff364fbc85dc7d8ffac5924?merge_request_iid=227 in the core merged all the no-op Determinize overloads into one.
This brings two issues.
First, the edges between boxes report cast issue
```
Type
automaton::DFA<Universal type, unsigned>
is not castable to type
variant<
automaton::DFA<Universal type, Universal type>,
automaton::DFTA<Universal type, Universal type>,
automaton::DPDA<Universal type, Universal type, Universal type>,
automaton::InputDrivenDPDA<Universal type, Universal type, Universal type>,
automaton::OneTapeDTM<Universal type, Universal type>,
automaton::RealTimeHeightDeterministicDPDA<Universal type, Universal type, Universal type>,
automaton::SinglePopDPDA<Universal type, Universal type, Universal type>,
automaton::UnorderedDFTA<Universal type, Universal type>,
automaton::VisiblyPushdownDPDA<Universal type, Universal type, Universal type>
>
```
Second, the overload in the algorithm list now reports this and I have no idea how to report the types of the variants.
![Snímek_z_2022-03-26_09-38-27](/uploads/0b0e5d260f70be57d0bd7240b9e9ad6a/Snímek_z_2022-03-26_09-38-27.png)
cc @travnja3 Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/75Add a form for automaton input2022-05-02T23:07:39+02:00Hana LitavskáAdd a form for automaton inputAdd form for table input. Discussed here https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/issues/51Add form for table input. Discussed here https://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/issues/51BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/73Fix height for boxes with more input parameters2022-03-25T15:31:16+01:00Hana LitavskáFix height for boxes with more input parametersFix height resizing ![node](/uploads/7acdba9dda5ef686c92c5c698446be0f/node.png)Fix height resizing ![node](/uploads/7acdba9dda5ef686c92c5c698446be0f/node.png)BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/71Add input and output boxes with Parse2022-04-19T17:35:22+02:00Hana LitavskáAdd input and output boxes with ParseAdd input and output boxes for string input that will be parsed to grammar, automaton... Using string::Parse templated algorithm.Add input and output boxes for string input that will be parsed to grammar, automaton... Using string::Parse templated algorithm.BPHana LitavskáHana Litavskáhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/70worker: Remove pipe communication2022-05-11T23:44:58+02:00Tomáš Peckaworker: Remove pipe communicationSee https://gitlab.fit.cvut.cz/algorithms-library-toolkit/automata-library/issues/223See https://gitlab.fit.cvut.cz/algorithms-library-toolkit/automata-library/issues/223Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/69server: enable compression over HTTP2022-02-25T12:07:21+01:00Tomáš Peckaserver: enable compression over HTTPThe server probably does not compress responses. Firefox dev console shows 550kB transferred and 550kB file. The compression should lower that significantly.
https://ktor.io/docs/compression.html#configure_content_typeThe server probably does not compress responses. Firefox dev console shows 550kB transferred and 550kB file. The compression should lower that significantly.
https://ktor.io/docs/compression.html#configure_content_typeTomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/67Return value tooltip on parameters2022-04-16T19:14:20+02:00Hana LitavskáReturn value tooltip on parametersSome algorithms have "return value" tooltip on parameter icons.
![return_value](/uploads/0726aaeaa642337459b610dee543a49e/return_value.png)Some algorithms have "return value" tooltip on parameter icons.
![return_value](/uploads/0726aaeaa642337459b610dee543a49e/return_value.png)BPhttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/66Reduce bundle size2022-02-20T13:55:19+01:00Tomáš PeckaReduce bundle sizeToday's build of 73460371 (this does not have the `algorithms.json` bundled anymore):
```
File sizes after gzip:
737.9 KB build/static/js/2.a28c4d21.chunk.js
35.84 KB build/static/js/main.364ca3d4.chunk.js
775 B build/stati...Today's build of 73460371 (this does not have the `algorithms.json` bundled anymore):
```
File sizes after gzip:
737.9 KB build/static/js/2.a28c4d21.chunk.js
35.84 KB build/static/js/main.364ca3d4.chunk.js
775 B build/static/js/runtime-main.595ff79e.js
135 B build/static/css/main.876345ae.chunk.css
```
Still too much I guess.
As per https://create-react-app.dev/docs/analyzing-the-bundle-size/:
Externals:
* 72.4% by viz.js (1.98 MB, graphviz dependency) !!!
* 6.2% by MUI (174 KB, not much to do I guess)
* 4.1% by react (114KB, not much to do I guess)
* 2.1% by immutable.js (60KB, used only for Maps in redux)
Our code is not that big.
Find out how to reduce viz.js size. Their [github repo](https://github.com/mdaines/viz.js/) says they compiled the C code with Emscripten :( Is there a way how not to bundle whole viz.js?Tomáš PeckaTomáš Peckahttps://gitlab.fit.cvut.cz/algorithms-library-toolkit/webui-client/-/issues/65We don't need to list all overloadeded functions2022-05-10T19:21:55+02:00Tomáš PeckaWe don't need to list all overloadeded functionsAs of now, we list all overloads of a function, e.g. `string::Compose`.
When user selects a `string::Compose` for e.g. `alphabet::BarSymbol` instead of `automaton::DFA`, it works, because the selection of the overload is left to the ALT,...As of now, we list all overloads of a function, e.g. `string::Compose`.
When user selects a `string::Compose` for e.g. `alphabet::BarSymbol` instead of `automaton::DFA`, it works, because the selection of the overload is left to the ALT, so it is actually not needed.
But we give user a visual warning that he chose a wrong overload (even if it works).
I'd like this to change.
* Let's list only one overload in the algorithm menu with a dropdown bar that shows all of them with appropriate docs (should the docs differ for every overload or should we unify the docs for all overloads?).
* Let's give the warning to the user only if he connects an edge from the box with a return value that cannot be used is absolutely not viable, i.e., it can't be used as an input for any of the overloads.
* However I am not sure how to deal with outputs of such overloaded box. Should we guess what the output is?BPHana LitavskáHana Litavská