cli: fix undefined behavior in dot algo

alib2cli/src/builtin/Dot.cpp

@@ -65,15 +65,14 @@ void Dot::dot2 ( const std::string & data ) {
 	dot ( data, true );
 }
-void Dot::dot ( const std::string & data, const std::string& outputType, const std::string & outputFile ) {
-	std::string outputTypeLower;
-	std::transform ( outputType.begin ( ), outputType.end ( ), outputTypeLower.begin ( ), ::tolower );
-	if ( std::find ( allowedOutputTypes.begin( ), allowedOutputTypes.end ( ), outputTypeLower ) == allowedOutputTypes.end ( ) ) {
-		throw exception::CommonException ( "Dot: Invalid output type." );
+void Dot::dot ( const std::string & data, std::string outputType, const std::string & outputFile ) {
+	std::transform ( outputType.begin ( ), outputType.end ( ), outputType.begin ( ), ::tolower );
+	if ( std::find ( allowedOutputTypes.begin( ), allowedOutputTypes.end ( ), outputType ) == allowedOutputTypes.end ( ) ) {
+		throw exception::CommonException ( "Dot: Invalid output type (" + outputType + ")." );
 	}
-	run ( data, outputTypeLower, outputFile, false );
+	run ( data, outputType, outputFile, false );
 }
@@ -89,7 +88,7 @@ auto DotTx11 = registration::AbstractRegister < Dot, void, const std::string &,
 @param dot a string containing dot data\n\
 @param background a flag specifying whether to run in background (does not block CLI input)" );
-auto DotFile = registration::AbstractRegister < Dot, void, const std::string &, const std::string &, const std::string & > ( Dot::dot, abstraction::AlgorithmCategories::AlgorithmCategory::DEFAULT, "data", "outputType", "outputFile" ).setDocumentation (
+auto DotFile = registration::AbstractRegister < Dot, void, const std::string &, std::string, const std::string & > ( Dot::dot, abstraction::AlgorithmCategories::AlgorithmCategory::DEFAULT, "data", "outputType", "outputFile" ).setDocumentation (
 "Cli builtin command for DOT format visualization. Runs dot -T<outputType> -o <outputFile> and blocks the input until done.\n\
 \n\
 @param data a string containing dot data\n\

alib2cli/src/builtin/Dot.h

@@ -34,7 +34,7 @@ public:
 	 * \param outputType the type of dot created image
 	 * \param outputFile the destination file name
 	 */
-	static void dot ( const std::string & data, const std::string & outputType, const std::string & outputFile );
+	static void dot ( const std::string & data, std::string outputType, const std::string & outputFile );
 protected:
 	/** Allowed output types */