fix some more clang-tidy errors

alib2abstraction/src/abstraction/PackingAbstraction.hpp

@@ -68,7 +68,7 @@ private:
 public:
 	bool inputsAttached ( ) const override {
 		for ( const std::shared_ptr < abstraction::OperationAbstraction > & operation : m_abstractions )
-			if ( operation->inputsAttached ( ) == false )
+			if ( ! operation->inputsAttached ( ) )
 				return false;
 		return true;

alib2algo/src/automaton/convert/ToRegExpStateElimination.h

@@ -83,7 +83,7 @@ private:
 	 * @return the regular expression node representing the transitions between states @p from and @p to
 	 */
 	template < class SymbolType, class StateType >
-	static const regexp::UnboundedRegExpStructure < SymbolType > transitionsToRegExp ( const automaton::ExtendedNFA < SymbolType, StateType > & automaton, const StateType & from, const StateType & to );
+	static regexp::UnboundedRegExpStructure < SymbolType > transitionsToRegExp ( const automaton::ExtendedNFA < SymbolType, StateType > & automaton, const StateType & from, const StateType & to );
 	/**
 	 * Helper function for the elimination of a single state according to the algorithm.
@@ -148,7 +148,7 @@ automaton::ExtendedNFA < SymbolType, StateType > ToRegExpStateElimination::elimi
 }
 template < class SymbolType, class StateType >
-const regexp::UnboundedRegExpStructure < SymbolType > ToRegExpStateElimination::transitionsToRegExp ( const automaton::ExtendedNFA < SymbolType, StateType > & automaton, const StateType & from, const StateType & to ) {
+regexp::UnboundedRegExpStructure < SymbolType > ToRegExpStateElimination::transitionsToRegExp ( const automaton::ExtendedNFA < SymbolType, StateType > & automaton, const StateType & from, const StateType & to ) {
 	regexp::UnboundedRegExpStructure < SymbolType > ret ( regexp::UnboundedRegExpEmpty < SymbolType > { } );
 	for ( const auto & transition: automaton.getTransitionsFromState ( from ) )

alib2algo/src/automaton/simplify/MinimizeDistinguishableStates.h

@@ -83,11 +83,11 @@ private:
 	 * @return state partitioning of undistinguishable states
 	 */
 	template < class StateType >
-	static const ext::map < StateType, ext::set < StateType > > partitionMap ( const ext::set < ext::set < StateType > > & partitions );
+	static ext::map < StateType, ext::set < StateType > > partitionMap ( const ext::set < ext::set < StateType > > & partitions );
 };
 template < class StateType >
-const ext::map < StateType, ext::set < StateType > > MinimizeDistinguishableStates::partitionMap ( const ext::set < ext::set < StateType > > & partitions ) {
+ext::map < StateType, ext::set < StateType > > MinimizeDistinguishableStates::partitionMap ( const ext::set < ext::set < StateType > > & partitions ) {
 	ext::map < StateType, ext::set < StateType > > res;
 	for ( const auto & partition : partitions )

alib2cli/src/ast/statements/StatementList.h

@@ -17,7 +17,7 @@ public:
 			throw std::invalid_argument ( "Statement list can't be empty" );
 		std::shared_ptr < abstraction::OperationAbstraction > next = m_statements [ 0 ]->translateAndEval ( nullptr, environment );
-		for ( unsigned i = 1; i < m_statements.size ( ); ++ i )
+		for ( size_t i = 1; i < m_statements.size ( ); ++ i )
 			next = m_statements [ i ]->translateAndEval ( next, environment );
 		return next;

alib2cli/src/command/ExecuteCommand.h

@@ -11,7 +11,7 @@ class ExecuteCommand : public Command {
 	std::shared_ptr < Statement > m_command;
 public:
-	ExecuteCommand ( std::shared_ptr < StatementList > command ) : m_command ( command ) {
+	ExecuteCommand ( std::shared_ptr < StatementList > command ) : m_command ( std::move ( command ) ) {
 	}
 	Command::Result run ( Environment & environment ) const override {

alib2cli/src/command/OverloadsIntrospectionCommand.h

@@ -43,7 +43,7 @@ public:
 					common::Streams::out << " &&";
 			}
 			common::Streams::out << " (";
-			for ( unsigned i = 0; i < std::get < 0 > ( overload ).getParams ( ).size ( ); ++ i ) {
+			for ( size_t i = 0; i < std::get < 0 > ( overload ).getParams ( ).size ( ); ++ i ) {
 				const ext::tuple < std::string, ext::set < abstraction::ParamQualifiers::ParamQualifier > > & parameter = std::get < 0 > ( overload ).getParams ( ) [ i ];
 				const std::string & name = std::get < 0 > ( overload ).getParamNames ( ) [ i ];
 				if ( i != 0 )

alib2cli/src/common/LibraryLoader.h

@@ -19,7 +19,7 @@ class LibraryLoader {
 		void * m_handle;
 	public:
-		Library ( const std::string & path ) : m_path ( path ), m_handle ( nullptr ) {
+		Library ( std::string path ) : m_path ( std::move ( path ) ), m_handle ( nullptr ) {
 			load ( );
 		}

alib2data/src/common/SparseBoolVector.hpp

@@ -60,26 +60,26 @@ private:
 	void packData ( ) {
 		size_t sizeWithin = m_Size % ( sizeof ( unsigned ) * BITS_IN_BYTE );
-		long long sizeBlocks = m_Size / ( sizeof ( unsigned ) * BITS_IN_BYTE ) + static_cast < unsigned > ( sizeWithin != 0 );
+		unsigned long long sizeBlocks = m_Size / ( sizeof ( unsigned ) * BITS_IN_BYTE ) + static_cast < unsigned > ( sizeWithin != 0 );
 		unsigned mask = getMask ( sizeWithin );
 		// crop by size
-		ext::list < element >::iterator elementIter;
-		for ( elementIter = m_Data.begin ( ); elementIter != m_Data.end ( ); ++ elementIter ) {
-			sizeBlocks -= elementIter->run + 1;
-			if ( sizeBlocks <= 0 )
+		ext::list < element >::iterator elementIter = m_Data.begin ( );
+		for ( ; elementIter != m_Data.end ( ); ++ elementIter ) {
+			if ( sizeBlocks <= elementIter->run + 1 )
 				break;
+			sizeBlocks -= elementIter->run + 1;
 		}
-		if ( sizeBlocks == 0 ) { // sizeBlocks is negative or 0
+		 // sizeBlocks is smaller or equal to elementIter->run + 1
+		if ( sizeBlocks == elementIter->run + 1 ) {
 			if ( mask != 0 )
 				elementIter->word &= mask;
-			++ elementIter;
 		} else {
-			elementIter->run += sizeBlocks; //sizeBlocks is negative
+			elementIter->run = sizeBlocks - 1;
 			elementIter->word = 0;
-			++ elementIter;
 		}
+		++ elementIter;
 		for ( ; elementIter != m_Data.end ( ); ) {
 			elementIter = m_Data.erase ( elementIter );

alib2gui/src/Models/InputModelBox.hpp

@@ -12,7 +12,7 @@ public:
     std::string getName() const override;
-    const std::shared_ptr<abstraction::OperationAbstraction> getAutomaton() const { return this->result; }
+    std::shared_ptr<abstraction::OperationAbstraction> getAutomaton() const { return this->result; }
     void setAutomaton(std::shared_ptr<abstraction::OperationAbstraction> automaton) { this->result = std::move(automaton); }
 };

alib2std/src/extensions/container/string.cpp

@@ -19,7 +19,7 @@ std::string to_string ( int value ) {
 }
 std::string to_string ( bool value ) {
-	return std::to_string ( value );
+	return std::to_string ( static_cast < int > ( value ) );
 }
 std::string to_string ( long value ) {
@@ -64,45 +64,42 @@ std::string from_string ( const std::string & value ) {
 template < >
 int from_string ( const std::string & value ) {
-	return std::stoi ( value.c_str() );
+	return std::stoi ( value );
 }
 template < >
 bool from_string ( const std::string & value ) {
-	if ( value == "true" || value == "1" )
-		return true;
-	else
-		return false;
+	return value == "true" || value == "1";
 }
 template < >
 long from_string ( const std::string & value ) {
-	return std::stol ( value.c_str() );
+	return std::stol ( value );
 }
 template < >
 long long from_string ( const std::string & value ) {
-	return std::stoll ( value.c_str() );
+	return std::stoll ( value );
 }
 template < >
 unsigned from_string ( const std::string & value ) {
-	return std::stoul ( value.c_str() );
+	return std::stoul ( value );
 }
 template < >
 unsigned long from_string ( const std::string & value ) {
-	return std::stoul ( value.c_str() );
+	return std::stoul ( value );
 }
 template < >
 unsigned long long from_string ( const std::string & value ) {
-	return std::stoull ( value.c_str() );
+	return std::stoull ( value );
 }
 template < >
 double from_string ( const std::string & value ) {
-	return std::stod ( value.c_str() );
+	return std::stod ( value );
 }
 ext::vector < std::string > explode ( const std::string & source, const std::string & delimiter ) {

alib2std/src/extensions/hexavigesimal.cpp

@@ -10,9 +10,9 @@
 namespace ext {
-unsigned fromBase26( std::string rep ) {
+unsigned fromBase26( const std::string & rep ) {
 	unsigned n = 0;
-	for(char repSymbol : rep ) {
+	for ( char repSymbol : rep ) {
 		unsigned remainder = repSymbol - 'A';
 		if(remainder > 26)
 			throw std::invalid_argument(rep);
@@ -32,9 +32,9 @@ std::string toBase26( unsigned n ) {
 	return std::string( name.rbegin( ), name.rend( ) );
 }
-unsigned bijectiveFromBase26 ( std::string rep ) {
+unsigned bijectiveFromBase26 ( const std::string & rep ) {
 	unsigned n = 0;
-	for (char repSymbol : rep ) {
+	for ( char repSymbol : rep ) {
 		unsigned remainder = repSymbol - 'A';
 		if(remainder > 26)
 			throw std::invalid_argument(rep);

alib2std/src/extensions/hexavigesimal.h

@@ -56,7 +56,7 @@ std::string toBase26( unsigned n );
  *
  * \return the number corresponding to the value in \p rep
  */
-unsigned fromBase26( std::string rep );
+unsigned fromBase26( const std::string & rep );
 /**
  * \brief
@@ -86,7 +86,7 @@ std::string bijectiveToBase26( unsigned n );
  *
  * \return the number corresponding to the value in \p rep
  */
-unsigned bijectiveFromBase26( std::string rep );
+unsigned bijectiveFromBase26( const std::string & rep );
 } /* namespace ext */

alib2std/src/extensions/typeindex.cpp

@@ -20,7 +20,7 @@ std::ostream & operator << ( std::ostream & os, const ext::type_index & type ) {
 std::string to_string ( const ext::type_index & type ) {
 	int status;
-	char* demangled = abi::__cxa_demangle(type.name(), 0, 0, &status);
+	char* demangled = abi::__cxa_demangle(type.name(), nullptr, nullptr, &status);
 	std::string res ( demangled );
 	free ( demangled );
 	return res;

alib2std/src/extensions/typeinfo.cpp

@@ -47,9 +47,9 @@ bool is_same_type ( const std::string & first, const std::string & second ) {
 	if ( explodedFirst.size ( ) > explodedSecond.size ( ) )
 		return false;
-	unsigned offset = explodedSecond.size ( ) - explodedFirst.size ( );
-	for ( unsigned index = 0; index < explodedFirst.size ( ); ++ index ) {
+	size_t offset = explodedSecond.size ( ) - explodedFirst.size ( );
+	for ( size_t index = 0; index < explodedFirst.size ( ); ++ index ) {
 		if ( explodedFirst [ index ].empty ( ) )
 			continue;

aql2/src/aql.cpp

@@ -14,7 +14,7 @@ template < class T, class U >
 std::istream& operator>> ( std::istream & in, std::pair < T, U > & value ) {
 	std::string tmp;
 	in >> tmp;
-	size_t posEqual = tmp.find ( "=" );
+	size_t posEqual = tmp.find ( '=' );
 	if ( posEqual == std::string::npos )
 		in.setstate(std::ios_base::failbit);