Skip to content
Snippets Groups Projects
Commit ee213d38 authored by Jan Trávníček's avatar Jan Trávníček
Browse files

clang-tidy: fix implicit narrowing conversion

int to char is expected so cast; double to in was incorrect should
return double
parent 020f1402
No related branches found
No related tags found
1 merge request!179C casts to C++ casts redesign
...@@ -9,7 +9,7 @@ char xmlApi < char >::parse ( ext::deque < sax::Token >::iterator & input) { ...@@ -9,7 +9,7 @@ char xmlApi < char >::parse ( ext::deque < sax::Token >::iterator & input) {
sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::START_ELEMENT, xmlTagName ( ) ); sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::START_ELEMENT, xmlTagName ( ) );
int data = ext::from_string < int > ( sax::FromXMLParserHelper::popTokenData ( input, sax::Token::TokenType::CHARACTER ) ); int data = ext::from_string < int > ( sax::FromXMLParserHelper::popTokenData ( input, sax::Token::TokenType::CHARACTER ) );
sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::END_ELEMENT, xmlTagName ( ) ); sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::END_ELEMENT, xmlTagName ( ) );
return data; return static_cast < char > ( data );
} }
   
bool xmlApi < char >::first ( const ext::deque < sax::Token >::const_iterator & input) { bool xmlApi < char >::first ( const ext::deque < sax::Token >::const_iterator & input) {
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
   
namespace core { namespace core {
   
int xmlApi < double >::parse ( ext::deque < sax::Token >::iterator & input ) { double xmlApi < double >::parse ( ext::deque < sax::Token >::iterator & input ) {
sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::START_ELEMENT, xmlTagName ( ) ); sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::START_ELEMENT, xmlTagName ( ) );
double data = ext::from_string < double > ( sax::FromXMLParserHelper::popTokenData ( input, sax::Token::TokenType::CHARACTER ) ); double data = ext::from_string < double > ( sax::FromXMLParserHelper::popTokenData ( input, sax::Token::TokenType::CHARACTER ) );
sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::END_ELEMENT, xmlTagName ( ) ); sax::FromXMLParserHelper::popToken ( input, sax::Token::TokenType::END_ELEMENT, xmlTagName ( ) );
......
...@@ -6,7 +6,7 @@ namespace core { ...@@ -6,7 +6,7 @@ namespace core {
   
template < > template < >
struct xmlApi < double > { struct xmlApi < double > {
static int parse ( ext::deque < sax::Token >::iterator & input ); static double parse ( ext::deque < sax::Token >::iterator & input );
static bool first ( const ext::deque < sax::Token >::const_iterator & input ); static bool first ( const ext::deque < sax::Token >::const_iterator & input );
static std::string xmlTagName ( ); static std::string xmlTagName ( );
static void compose ( ext::deque < sax::Token > & output, double data ); static void compose ( ext::deque < sax::Token > & output, double data );
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment