Jan Trávníček authored 3 years ago and Tomáš Pecka committed 3 years ago

MP algorithm was always resetting the pattern index to 0 whereas it should be
reused. This revealed that Spos should also take into account node wildcards
otherwise the presumed not-necessary-to-be-parsed part of the pattern does not
have to be matching the pattern. Which caused the computation of what does not
need to be matched to underflow.

Jan Trávníček authored 3 years ago and Tomáš Pecka committed 3 years ago

a step forward to remove any need for container extensions

While working on webui, I have noticed that exports from
automata-library contain for many algorithms documentation set to
string "Documentation not available.". I traced the problem back to this
project.

I do not think "Documentation not available" is itself a valid
documentation of an algorithm so I decided to replace the std::string
that is supposed to hold documentation of an overload with an
std::optional<std::string>. The semantics should now be clearer.

While working on a webui I noticed that some algos have documentation
set to "Documentation not avaiable" instead of available. That's a typo
with multiple occurrences throughout the project.

In some cases, one wants to use system TClap (for instance, when one has
patched tclap installed)

Fixes: 7c0adf3e
Bug: algorithms-library-toolkit/automata-library#214

Long story short, tclap<=1.2.4 does not work with g++-11 compiler. We
sent a patch into TClap which was merged [1], however, new version was
not yet released so the distros have not included the fix in the
packaged versions of TClap.

This is becoming kind of a blocker for people who want to compile ALT.
I figured out that CMake can download external projects and if you do
things *magically right* [2] you can also convince the external projects
to be built before your project so you can depend on them.
So, CMake should now download TClap if you configure it to build aql2.
As tclap is header-only, compilation of aql2 modules should include the
directory where tclap is downloaded (and prefer it to the /usr/include
system path).
Unfortunately, tclap triggers a lot of warnings for us (hi,
-Wsuggest-override and -Werror) that we haven't seen before because
system headers do not trigger warnings. Fortunately, CMake can configure
includes to be SYSTEM includes (and use -isystem instead -I for g++
builds) which make things working again. However, this is just a really
big hack, AFAIK.

(I, personally, still think we should use some new, C++17-ready argument
parsing library. There is plenty of them.)

[1] https://sourceforge.net/p/tclap/code/ci/52a118c0edb20f64e8da88dc9d0bfee63f2232ac/
[2] https://crascit.com/2015/07/25/cmake-gtest/

Bug: #214
Bug: https://sourceforge.net/p/tclap/bugs/33/

Tomáš Pecka authored 4 years ago and Jan Trávníček committed 3 years ago

Configuration for YouCompleteMe[1] is developer's configuration, no
need to have it inside the repository.

[1] https://github.com/ycm-core/YouCompleteMe

Tomáš Pecka authored 4 years ago and Jan Trávníček committed 3 years ago

Many data structures had wrong spacing when outputting with operator<<
for the data structure. For example, see the missing space between
content and alphabet in string::LinearString.

 (LinearString content = [a, a, c, c, a]alphabet = {a, c})

Let's fix that, it bothered me for quite a long time.