it was replaced with a constraint

methods ext::Variant < ... >::set are joined + refactored to fix the std::move
vs std::forward issue

concepts are language native construct that was introduced to replace enable_if
(SFINAE)

moving is actually more expensive for shared_ptrs

constructor accepting an universal reference may interfere with move constructor

add const qualification, remove explicit initialization of string to empty, and
unify parameter names between declaration and definition

primitive types don't need std::move

remove unnecessary move of an integral value, add const qualifier to a method
that does not change the this object and remove another use of _identifier

virtual should start dynamic binding override checks dynamic binding is enabled
in base class

lambda is more efficient then bind

_identifiers are reserved for use for instance in the standard library

Tomáš Pecka authored 4 years ago and Jan Trávníček committed 4 years ago

Although #pragma once is not a standard, compilers nowadays usually
support it. We don't have any tricky build system so we should be OK.

This also fixes many errors regarding using reserved identifiers (names
starting with double underscore).

removal of an unnecessary recursion, addition of forgotten move, removal of
unnecessary const qualifier, change int to -> size_t

the generator is parametrized with number of states, initial states, and final
states; additionally duplicate, redundant, unreachable states are generated

transition function is filled in transition partitions:
{state, unreachable, redundant} vs {state, unreachable, redundant}

The epsilon transitions from the new initial state were labelled with empty,
should be epsilon

const regerence and rvalue reference may be simulated by value semantics

The register class should have explicit constructors, the member variable data should
be initialized in the member initializer list, should be named m_data, and the
finish callback should accept the data by const reference

Explicit constructors, transform, and any_of

Add explicit to constructors, refactor code to use standard library algorithms
more.