F36 is not released yet [1] and it contains not-yet-released g++-12
which causes some problems for our code. Let's deal with it once g++-12
is released.

[1] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

unique ptr is convertible to shared ptr natively. It makes sense to construct
unique_ptr first and convert it to shared_ptr if it is needed.

Most likely a remnant of abstraction refactoring to OperationAbstraction and
Value where Value is using the functionality, not the OperationAbstraction

prior to new normalization that needs to put code there

Tomáš Pecka authored 3 years ago and Tomáš Pecka committed 3 years ago

Also, I think that opensuse packagers are strange. Why the hell are
there gcc-c++ packages with default version of 7.5 in Leap 15.2 and
15.4?
So in order to build for different Leap versions I have to explicitly
specify build requirement to gcc<version>-c++? Why can't it be a single
package with bumped versions?

Tomáš Pecka authored 3 years ago and Tomáš Pecka committed 3 years ago

OpenSuse Leap package builds fail with undefined reference to dlclose
and dlopen. The -ldl link flag is missing (see the error below).
Let's fix that by adding the ${CMAKE_DL_LIBS} link target [1] to
alib2cli.

 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/alib2cli.dir/src/common/LibraryLoader.cpp.o: in function `cli::LibraryLoader::Library::unload()':
 /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:44: undefined reference to `dlclose'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:44: undefined reference to `dlclose'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/alib2cli.dir/src/common/LibraryLoader.cpp.o: in function `cli::LibraryLoader::Library::load()':
 /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:37: undefined reference to `dlopen'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:39: undefined reference to `dlerror'
 collect2: error: ld returned 1 exit status
 make[2]: *** [alib2cli/CMakeFiles/alib2cli.dir/build.make:500: alib2cli/libalib2cli.so.0.0.0] Error 1
 make[1]: *** [CMakeFiles/Makefile2:1017: alib2cli/CMakeFiles/alib2cli.dir/all] Error 2
 make[1]: *** Waiting for unfinished jobs....
 make: *** [Makefile:150: all] Error 2

[1] https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html

Tomáš Pecka authored 3 years ago and Tomáš Pecka committed 3 years ago

I don't think we should add RPATH information into our binaries. The
dynamic libraries are installed into correct folders so let the OS find
them.
Some distributions also do not like setting RPATHs [1].

[1] https://en.opensuse.org/openSUSE:Packaging_checks#Beware_of_Rpath

Tomáš Pecka authored 3 years ago and Tomáš Pecka committed 3 years ago

This would have been simpler with rules in gitlab 12, but we don't have
it yet.