The parents were set incorrectly in swap of trees and tries. Parents in children
of swapped objects should be set, not the parents in swapped objects.

The template function sort internally called swap so it internaly tests
swap of trees

Take out common code in then and else branch

The case (b*+a)* was only optimized to (b+a)* by lemma V4.

This test generates a random automaton, runs both iteration algorithms on
it and then tests that both these automata accept equal language.

This is first of the aql integration tests (which support was added in
commit d79fe028). This should serve as
an example how to write aql integration tests.
Also, this is something that should not be in the unit tests (and it
was removed in the previous commits).

Algorithm automaton::transform::AutomatonIteration resulted in wrong
output when the input automaton had a transition from the initial state to a
final state.
If such transitions exists, we must also add a transition from the new
initial state to the old initial state in the new automata.

Added a test case for this particular case.

Closes #211

The tests for iteration were "messy". It was not clear what are they
doing and also we tested two algorithms in one test case.

Split those algorithms and make them clear -- test only for expected
output.

There were two instances of the AutomatonIteration::iteration method,
one for working with DFAs, one for NFAs. However, both shared the same
code.
Let's merge those methods.

protected field break encapsulation

it was replaced with a constraint

methods ext::Variant < ... >::set are joined + refactored to fix the std::move
vs std::forward issue

concepts are language native construct that was introduced to replace enable_if
(SFINAE)

moving is actually more expensive for shared_ptrs

constructor accepting an universal reference may interfere with move constructor

add const qualification, remove explicit initialization of string to empty, and
unify parameter names between declaration and definition

primitive types don't need std::move

remove unnecessary move of an integral value, add const qualifier to a method
that does not change the this object and remove another use of _identifier

virtual should start dynamic binding override checks dynamic binding is enabled
in base class

lambda is more efficient then bind

_identifiers are reserved for use for instance in the standard library

Tomáš Pecka authored 4 years ago and Jan Trávníček committed 4 years ago

Although #pragma once is not a standard, compilers nowadays usually
support it. We don't have any tricky build system so we should be OK.

This also fixes many errors regarding using reserved identifiers (names
starting with double underscore).