unique ptr is convertible to shared ptr natively. It makes sense to construct
unique_ptr first and convert it to shared_ptr if it is needed.

Tomáš Pecka authored 3 years ago and Tomáš Pecka committed 3 years ago

OpenSuse Leap package builds fail with undefined reference to dlclose
and dlopen. The -ldl link flag is missing (see the error below).
Let's fix that by adding the ${CMAKE_DL_LIBS} link target [1] to
alib2cli.

 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/alib2cli.dir/src/common/LibraryLoader.cpp.o: in function `cli::LibraryLoader::Library::unload()':
 /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:44: undefined reference to `dlclose'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:44: undefined reference to `dlclose'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/alib2cli.dir/src/common/LibraryLoader.cpp.o: in function `cli::LibraryLoader::Library::load()':
 /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:37: undefined reference to `dlopen'
 /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /build/pkg/build/pkgs/opensuse-leap-15.3/algorithms-library-snapshot-0.0.0.r1277.gf2a2ccf62-1/rpmbuild/BUILD/algorithms-library-v0.0.0.r1277.gf2a2ccf62/alib2cli/src/common/LibraryLoader.h:39: undefined reference to `dlerror'
 collect2: error: ld returned 1 exit status
 make[2]: *** [alib2cli/CMakeFiles/alib2cli.dir/build.make:500: alib2cli/libalib2cli.so.0.0.0] Error 1
 make[1]: *** [CMakeFiles/Makefile2:1017: alib2cli/CMakeFiles/alib2cli.dir/all] Error 2
 make[1]: *** Waiting for unfinished jobs....
 make: *** [Makefile:150: all] Error 2

[1] https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html

Jan Trávníček authored 3 years ago and Jan Trávníček committed 3 years ago

breaking change!

Jan Trávníček authored 3 years ago and Tomáš Pecka committed 3 years ago

a step forward to remove any need for container extensions

While working on webui, I have noticed that exports from
automata-library contain for many algorithms documentation set to
string "Documentation not available.". I traced the problem back to this
project.

I do not think "Documentation not available" is itself a valid
documentation of an algorithm so I decided to replace the std::string
that is supposed to hold documentation of an overload with an
std::optional<std::string>. The semantics should now be clearer.

... because most developers were copy-pasting the preambule anyway and
did not pay any attention to change it.

Also, I think that git does better job in managing that.

constructor accepting an universal reference may interfere with move constructor

add const qualification, remove explicit initialization of string to empty, and
unify parameter names between declaration and definition