In the context the order of iterators is that the returned value is
always positive

ints unnecessarily reduce range of values for indexes

remove not needed cast

Map keys are exactly corresponding to vector indexes in the algorithm.

getRank used to return a class that was supposed to be compatible with
unsigned (and size_t) however now it is unsigned by itself

... because most developers were copy-pasting the preambule anyway and
did not pay any attention to change it.

Also, I think that git does better job in managing that.

The case (b*+a)* was only optimized to (b+a)* by lemma V4.

Algorithm automaton::transform::AutomatonIteration resulted in wrong
output when the input automaton had a transition from the initial state to a
final state.
If such transitions exists, we must also add a transition from the new
initial state to the old initial state in the new automata.

Added a test case for this particular case.

Closes #211

The tests for iteration were "messy". It was not clear what are they
doing and also we tested two algorithms in one test case.

Split those algorithms and make them clear -- test only for expected
output.

There were two instances of the AutomatonIteration::iteration method,
one for working with DFAs, one for NFAs. However, both shared the same
code.
Let's merge those methods.

Tomáš Pecka authored 4 years ago and Jan Trávníček committed 4 years ago

Although #pragma once is not a standard, compilers nowadays usually
support it. We don't have any tricky build system so we should be OK.

This also fixes many errors regarding using reserved identifiers (names
starting with double underscore).

removal of an unnecessary recursion, addition of forgotten move, removal of
unnecessary const qualifier, change int to -> size_t

Also make the test section names more clear

I redesigned the algorithm to make it similar to NPDA run implementation, most
importantly to handle cycles, also not even the very basic test that I
introduced didn't pass.

Additionaly, the graphStructuredStacks used to track the pushdown store and output were
incorrectly parametrized with InputSymbolType instead of PushdownStoreSymbolType
and OutputSymbolType.

NPDA execution through BFS-like simulation. Only exposed via Accept algo.

The variable i can be constructed from the begin and current iterator to the
input.

The ToAutomaton should be an aggregate/alias for the default algorithms.